test(server): lock DirectoryScanner max_depth clipping#10291
Open
Bartok9 wants to merge 2 commits into
Open
Conversation
Add regression coverage for the silent depth cut that drops nested notebooks from the home Workspace tree (see issue 10064). Signed-off-by: Bartok9 <danielrpike9@gmail.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
Author
|
I have read the CLA Document and I hereby sign the CLA |
for more information, see https://pre-commit.ci
Bartok9
marked this pull request as ready for review
July 23, 2026 22:51
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request was authored by a coding agent.
AI-assisted; human-reviewed line-by-line. Submitted under Daniel's standing Top10 merge-culture campaign instruction for Bartok9.
Summary
Regression tests for
DirectoryScanner'smax_depthbehavior — the silent clip that drops notebooks nested deeper than the scan limit on the home Workspace tree.Related: #10064
Motivation
Users opening
marimo editfrom a broad root (e.g.$HOME) lose deep project notebooks from the Workspace panel with no error. That is the current scanner contract (MAX_DEPTH = 5, subdirs not entered at the limit). These tests pin the contract so a future homepage rework cannot accidentally regress the depth math silently.What is tested
max_depthare omitted (including intermediate folders with no remaining children).Out of scope
No product/UI change (no warning banner yet — maintainers noted a homepage rework). Companion docs PR documents the user-facing limits separately.
Verification
Reproduced the two scenarios against current
mainscanner logic locally (all assertions green). Test-only diff ontests/_server/test_directory_scanner.py.Agent-Owner:
sera· Platform: hermes · Claim-TTL: 24h