-
Notifications
You must be signed in to change notification settings - Fork 1.2k
fix(export): wrap long code lines in WebPDF export #10295
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
Abdulrehman-PIAIC80387
wants to merge
3
commits into
marimo-team:main
Choose a base branch
from
Abdulrehman-PIAIC80387:fix/pdf-code-line-wrapping-9421
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+91
β0
Draft
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nitpick, but could we directly test
_render_webpdf_with_nbconverthere? This test registers_inline_code_wrap_cssitself, so it would still pass if the production registration were removed. We could patchWebPDFExporter.run_playwrightto capture the generated HTML and return dummy PDF bytes.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch β you're right, and it was a real gap rather than a nitpick: dropping the
register_preprocessorcall from_render_webpdf_with_nbconvertleft the old test green.Fixed in c8a212a. It now drives
_render_webpdf_with_nbconvertdirectly and stubsWebPDFExporter.run_playwright, which receives the fully rendered HTML β so the assertion covers the real registration, still without needing Chromium.Verified by mutation: with the production
register_preprocessorcall removed the test fails, and passes with it restored.