improvement: single '_' function names to work with linting#3143
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
dmadisetti
reviewed
Dec 12, 2024
dmadisetti
left a comment
dmadisetti
left a comment
Member
There was a problem hiding this comment.
Changes look pretty straight forward, 2 thoughts:
- Is it worth preventing the user from naming a cell _ or __? Or does that restriction already exist
- If mypy is a standard that marimo wants to hold itself to, it might be worth adding tests to check some of the generated files: https://mypy.readthedocs.io/en/stable/extending_mypy.html these would also be a starting point for adding any other top level file changes
Otherwise +1 !
Contributor
Author
|
akshayka
approved these changes
Dec 12, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change makes the code-generation output mypy/pyright compliant
Fixes #1954
Fixes #2325