feat: add auto-fix for multiple definctions and popular imports#3343
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
mscolnick
marked this pull request as draft
January 4, 2025 05:07
mscolnick
commented
Jan 4, 2025
| tf: "import tensorflow as tf", | ||
| torch: "import torch", | ||
| xr: "import xarray as xr", | ||
| }; |
Contributor
Author
There was a problem hiding this comment.
could probably consolidate this
akshayka
reviewed
Jan 4, 2025
mscolnick
marked this pull request as ready for review
January 6, 2025 13:58
akshayka
previously approved these changes
Jan 6, 2025
akshayka
left a comment
akshayka
left a comment
Contributor
There was a problem hiding this comment.
This is awesome! I played with it, and it works well. Just one comment on formatting.
| ...indentLines(linesBeforeLastStmt, indentation), | ||
| `${indentation}return ${linesRest[0]}`, | ||
| ...indentLines(linesRest.slice(1), indentation), | ||
| "_()", |
Contributor
There was a problem hiding this comment.
Can you insert two blank lines before _()? To make it roughly match what ruff format would generate.
Contributor
|
🚀 Development release published. You may be able to view the changes at https://marimo.app?v=0.10.10-dev21 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #3110
This adds two autofixes for different marimo errors. This opens the door for more autofixes as well. Right now this happens on all the frontend because 1) the code transformations are not that difficult and 2) still requires frontend logic like focusing the editor or adding a new cell. We could move some of this to the backend but would prefer to put the auto-fixes into a a proper linting framework + LSP.
The autofixes: