ci: run pre-commit on pull requests#87
Merged
Merged
Conversation
dmadisetti
approved these changes
Jul 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What / why
This repo ships a
.pre-commit-config.yaml, but nothing was actually running it: pre-commit.ci is not installed on this repo, and no CI workflow invoked the hooks. That means contributors without local pre-commit installed silently bypass trailing-whitespace/EOF, YAML, and ruff (lint + format) checks — the config was dead weight.This adds a
pre-commitGitHub Actions workflow that runs the existing hooks on every pull request (and on pushes tomain), so the config is actually enforced.The workflow
uvx pre-commit run --all-files --show-diff-on-failureviaastral-sh/setup-uv.permissions: contents: read) — it reports failures with a diff rather than auto-pushing fixes.~/.cache/pre-commitkeyed on the config hash.Autofixes included
None — running
pre-commit run --all-filesonmainpasses cleanly today:Part of the marimo-team engineering-excellence initiative to make sure every repo's declared quality gates actually run in CI.