feat: send WebSocket ping frames#17
Open
qwertycxz wants to merge 3 commits into
Open
Conversation
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Adds an optional WebSocket keepalive ping interval configurable via CLI and server options to help keep idle connections alive.
Changes:
- Added
pingoption tostartWebSocketServerand threaded it intohandleWebSocketConnection. - Implemented per-connection
setIntervalto send WebSocket ping frames and cleared it on socket close. - Exposed
--ping <ms>in CLI help and argument defaults.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| src/stdio-to-ws.ts | Adds ping option and per-connection ping timer lifecycle management. |
| src/main.ts | Adds CLI flag/default wiring for --ping and passes it to server start. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+99
to
+100
| if (ping) { | ||
| interval = setInterval(() => webSocket.ping(), ping); |
Author
There was a problem hiding this comment.
IMO, it is not quite necessary.
Comment on lines
+98
to
+101
| let interval: NodeJS.Timeout | null = null; | ||
| if (ping) { | ||
| interval = setInterval(() => webSocket.ping(), ping); | ||
| } |
Author
|
Hi @marimo-team, just a gentle ping on my PR #17 — it’s been a week and I’d love to get some feedback when you have a moment. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduce a
--ping <ms>option, adds support for sending periodic WebSocket ping frames to clients.