chore(ci): remove redundant npm@latest upgrade#33
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Removes a redundant npm upgrade step from the NPM release GitHub Actions workflow, aiming to rely on the npm version bundled with the configured Node.js runtime for OIDC trusted publishing.
Changes:
- Removed the
npm install -g npm@lateststep from the release workflow to avoid an extra global install in anid-token: writejob.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
23
to
27
| - name: ⎔ Setup Node.js | ||
| uses: actions/setup-node@49933ea5288caeca8642d1e84afbd3f7d6820020 # v4 | ||
| with: | ||
| node-version: 22 | ||
| registry-url: "https://registry.npmjs.org" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
node-24 ships with npm 11+ which already supports OIDC trusted publishing, so the
npm install -g npm@lateststep is redundant. Removing it also drops one global install in the same job asid-token: write.