Skip to content

XASDoc update concurrent with pymatgen update #1176

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

esoteric-ephemera
Copy link
Collaborator

Very minor fix related to the XASDoc - previously we relied on the XAS class in pymatgen to fail to construct when too many non-positive frequencies were passed in. Now that an exception is no longer thrown, the document model just needs to patch non-positive frequencies on the fly.

@codecov-commenter
Copy link

codecov-commenter commented Jan 21, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.18%. Comparing base (a1b5ff2) to head (6154b1c).

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #1176       +/-   ##
===========================================
+ Coverage   72.13%   90.18%   +18.05%     
===========================================
  Files          77      147       +70     
  Lines        5149    14503     +9354     
===========================================
+ Hits         3714    13080     +9366     
+ Misses       1435     1423       -12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@esoteric-ephemera esoteric-ephemera merged commit 200c970 into materialsproject:main Jan 23, 2025
8 checks passed
@esoteric-ephemera esoteric-ephemera deleted the xas_part_2 branch January 23, 2025 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants