Skip to content

Resolve mypy issues in emmet-api #1185

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 30, 2025

Conversation

esoteric-ephemera
Copy link
Collaborator

Fixing mypy issues in emmet-api related to the fact that pymatgen's Composition can take Element, Species, and DummySpecies as keys, and only the former two have a name attr that is a str

@codecov-commenter
Copy link

codecov-commenter commented Jan 29, 2025

Codecov Report

Attention: Patch coverage is 75.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 90.18%. Comparing base (2746902) to head (9f5a0ef).
Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
.../api/routes/materials/materials/query_operators.py 75.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1185   +/-   ##
=======================================
  Coverage   90.18%   90.18%           
=======================================
  Files         147      147           
  Lines       14503    14504    +1     
=======================================
+ Hits        13080    13081    +1     
  Misses       1423     1423           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@esoteric-ephemera
Copy link
Collaborator Author

@tsmathis and @tschaume ok to merge? There's something up with the latest pymatgen release (2025.1.4) that is also causing problems in atomate2 - need to investigate that to release the version pin

@esoteric-ephemera esoteric-ephemera merged commit 0f4432a into materialsproject:main Jan 30, 2025
8 checks passed
@esoteric-ephemera esoteric-ephemera deleted the api branch January 30, 2025 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants