Updating all type annotations to >3.10 conventions #1246
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tsmathis
force-pushed
the
emmet-type-annotations-updates
branch
from
f1186df to
dde2ff0
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #1246 +/- ##
==========================================
- Coverage 89.55% 89.53% -0.03%
==========================================
Files 150 150
Lines 15368 15303 -65
==========================================
- Hits 13763 13701 -62
+ Misses 1605 1602 -3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
tsmathis
force-pushed
the
emmet-type-annotations-updates
branch
from
dde2ff0 to
7168a54
Compare
remove 'Optional' annotations update 'List' annotations to 'list' update 'Dict' annotations to 'dict' update 'Tuple' annoatations to 'tuple' Remove 'Union' annotations
differs vs. 'typing._GenericAlias'
tsmathis
force-pushed
the
emmet-type-annotations-updates
branch
from
7168a54 to
41ab593
Compare
|
just a reminder on this one @tschaume |
tschaume
approved these changes
Jun 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ripping the bandaid off -_-
making diffs easier to parse in #1243