fix(memory): reject empty search queries#5258
Merged
kartik-mem0 merged 1 commit intoJun 8, 2026
Merged
Conversation
6 tasks
Contributor
|
LGTM. This is the strongest fix in this batch — it covers both |
This was referenced Jun 8, 2026
kartik-mem0
approved these changes
Jun 8, 2026
kartik-mem0
added a commit
that referenced
this pull request
Jun 10, 2026
Python v2.0.5 additions: - feat: add explain=True search score breakdowns (#5102) - fix(memory): reject empty/whitespace search queries (#5258) - fix(llms/xai): forward tools, add XAIConfig, parse tool_calls (#5190) - fix(pgvector): use open=False to prevent ConnectionPool hang in Docker (#5155) - fix(vector-stores): filter S3 vector list results client-side (#5018) - fix(vector_stores): Upstash namespace passed as top-level kwarg (#5202) TypeScript v3.0.7 additions: - feat: add explain search score breakdowns (#5102) - fix(embeddings): request float encoding_format from OpenAI (#5170)
7 tasks
KirtiRamchandani
added a commit
to KirtiRamchandani/mem0
that referenced
this pull request
Jun 14, 2026
feat(memory): add search score explanations (mem0ai#5102) docs: match migration callout color styling (mem0ai#5157) feat(server): add information on self-hosted dashboard (mem0ai#5325) fix(memory): reject empty search queries (mem0ai#5258) mem0-plugin hooks: honor auto_save=false in capture entry points (mem0ai#5450)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Memory.search()before lemmatization, embedding, or vector-store calls.MemoryClient.search()before sending API requests.Fixes #5220.
Verification
/Users/ritwij/.cache/codex-runtimes/codex-primary-runtime/dependencies/python/bin/python3 -m pytest tests/test_main.py::TestSearchParamValidation tests/test_client.py::TestSearchEntityParamRejection -q(20 passed)/Users/ritwij/.cache/codex-runtimes/codex-primary-runtime/dependencies/python/bin/python3 -m ruff check mem0/memory/main.py mem0/client/main.py tests/test_main.py tests/test_client.pygit diff --check