fix: expose Qdrant https option#5380
Conversation
|
The remaining red Vercel status is the repository-side preview authorization gate, not a build or test failure from this branch. The status target is �ercel.com/git/authorize for the Mem0 team, which I cannot authorize from the fork. No branch changes from me here unless a code-owned check fails or a maintainer wants the preview disabled for this PR. |
Changes RequestedStrengths
IssuesImportant (should fix)
Minor (optional)
Duplicate cluster noteThere are three other open PRs addressing the same thing: #5390, #5397, and #5400. #5390 already includes the docs update and additional tests, so if it's otherwise clean it would be the one to merge. If #5390 has problems, this PR is the tidiest base — the one docs line above would make it complete. Evidence
AssessmentReady to merge: With fixes — the implementation and tests are solid; the one blocker is the missing docs row. Please add it (and optionally link the related issue) and this is ready to squash. |
0c0837c to
e96f7f2
Compare
|
Thanks for the detailed review. I pushed an update that addresses the blocker here:
I also re-ran the focused checks locally:
All passed. I saw the duplicate cluster as well; this branch now keeps the narrower constructor-forwarding test coverage, so I'll leave the merge choice to maintainers rather than adding more churn. |
|
Verified against e96f7f2. LGTM — ready for human review & squash-mergeWhat this PR doesExposes the Strengths
IssuesNone. Evidence
AssessmentReady to merge: Yes (squash) · Est. human time: ~2 min |
Summary
httpsoption to the Qdrant vector-store configQdrantClientCloses #5378
To verify
python -m pytest tests\vector_stores\test_qdrant_config.py -qpython -m py_compile mem0\configs\vector_stores\qdrant.py mem0\vector_stores\qdrant.py tests\vector_stores\test_qdrant_config.pypython -m ruff check mem0\configs\vector_stores\qdrant.py mem0\vector_stores\qdrant.py tests\vector_stores\test_qdrant_config.pygit diff --checkNotes
ruff format --checkwould reformat existing unrelated lines inmem0/vector_stores/qdrant.py, so I did not run a full-file format pass for this small compatibility fix.