fix: use git bash for shell commands on windows to reduce generator failures #290
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ailures Signed-off-by: Chapman Pendery <[email protected]>
…ters on windows Signed-off-by: Chapman Pendery <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a constraint with the current cd spec from fig. It uses
ls -1ApLto generate the folder list, which will fail in pwsh.This PR addresses the issue by using Git Bash for generators on Windows. On Linux, having
/bin/shas a default will already fix this issue. Users without Git Bash installed will still have issues with cd, but that is an issue at the Fig spec level. I don't want to bring custom specs into inshellisense, so this is the best solution for now.Closes #12