Skip to content

Python: fix parsing of types in mcp server #12871

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 7, 2025

Conversation

eavanvalkenburg
Copy link
Member

@eavanvalkenburg eavanvalkenburg commented Aug 6, 2025

Motivation and Context

The parsing of tool call output was not working correctly, this fixes that.
Solves #12850

Description

Contribution Checklist

@eavanvalkenburg eavanvalkenburg requested a review from a team as a code owner August 6, 2025 09:16
@moonbox3 moonbox3 added the python Pull requests for the Python Semantic Kernel label Aug 6, 2025
@moonbox3
Copy link
Collaborator

moonbox3 commented Aug 6, 2025

Python Test Coverage

Python Test Coverage Report •
FileStmtsMissCoverMissing
connectors
   mcp.py42320751%75, 87, 95–102, 108–109, 114, 126–133, 141–145, 147–148, 150, 157–159, 244–250, 285–287, 292–294, 308–309, 312–313, 321–323, 335–336, 340–341, 343, 345, 347–353, 357–359, 361–371, 375–376, 380–381, 385, 387, 391–392, 396, 410, 425–433, 439–440, 442–443, 446–447, 453–454, 469–470, 473–474, 477–482, 486–487, 490–491, 494–500, 574, 576, 643, 645, 647, 649, 718, 720, 722, 724, 726, 784, 827–832, 834–837, 842, 895, 897, 900, 913, 933–935, 942–947, 950–953, 956–958, 962–966, 969–970, 979–980, 982–984, 998–999, 1001–1002, 1004–1006, 1009, 1016–1019, 1027, 1032–1037, 1042, 1044, 1047–1050
TOTAL26790458782% 

Python Unit Test Overview

Tests Skipped Failures Errors Time
3680 22 💤 0 ❌ 0 🔥 2m 0s ⏱️

@eavanvalkenburg eavanvalkenburg added this pull request to the merge queue Aug 7, 2025
Merged via the queue into microsoft:main with commit a6b5f34 Aug 7, 2025
30 checks passed
@eavanvalkenburg eavanvalkenburg deleted the mcp_image_fix branch August 7, 2025 21:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
python Pull requests for the Python Semantic Kernel
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants