Skip to content

.Net: Fix serialization/deserialization bug in InMemory VectorStore Extensions #12878

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 11, 2025
Merged

.Net: Fix serialization/deserialization bug in InMemory VectorStore Extensions #12878

merged 1 commit into from
Aug 11, 2025

Conversation

westey-m
Copy link
Contributor

@westey-m westey-m commented Aug 6, 2025 •
edited by rogerbarreto
Loading

Motivation and Context

Description

  • Fixing bug where serialized data includes updated internal storage type but deserialization did not.

Contribution Checklist

@westey-m westey-m requested a review from a team as a code owner August 6, 2025 15:30
@moonbox3 moonbox3 added the .NET Issue or Pull requests regarding .NET code label Aug 6, 2025
@github-actions github-actions bot changed the title Fix serialization/deserialization bug in InMemory VectorStore Extensions .Net: Fix serialization/deserialization bug in InMemory VectorStore Extensions Aug 6, 2025
@westey-m westey-m added this pull request to the merge queue Aug 11, 2025
Merged via the queue into microsoft:main with commit 4b60913 Aug 11, 2025
21 checks passed
@westey-m westey-m deleted the inmemory-json-roundtrip-bugfix branch August 11, 2025 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rogerbarreto rogerbarreto rogerbarreto approved these changes

@markwallace-microsoft markwallace-microsoft markwallace-microsoft approved these changes

+1 more reviewer

@shethaadit shethaadit shethaadit approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
.NET Issue or Pull requests regarding .NET code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

.Net: Bug: InMemoryVectorStore DeserializeCollectionFromJsonAsync error
5 participants
@westey-m @shethaadit @rogerbarreto @markwallace-microsoft @moonbox3