fixing many to many relationships on data_record resource #323
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
polatengin
requested review from
mawasile,
mattdot,
leighatami,
ianjensenisme and
eduardodfmex
as code owners
mattdot
approved these changes
Jun 6, 2024
mattdot
changed the title
eduardodfmex
approved these changes
Jun 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes a change in the
GetEntityRelationDefinitionInfofunction in theinternal/powerplatform/services/data_record/api_data_record.gofile. The change involves adding an additional condition to the if statements that check theEntity1NavigationPropertyNameandEntity2NavigationPropertyNamevalues. The new condition checks if theEntity1LogicalNameandEntity2LogicalNamevalues are not equal to theentityLogicalName. This change ensures that thetableNameis only set when the logical name of the entity does not match theentityLogicalName, providing a more precise selection of the table name.fixing determining wrong primary id field name for the referenced navigation propertyfixing determining wrong primary id field name for the referenced navigation property