Improving documentation of importing resources #403
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattdot
added
bug
10 tasks
mawasile
previously approved these changes
Sep 2, 2024
mattdot
commented
Sep 4, 2024
mattdot
commented
Sep 4, 2024
examples/resources/powerplatform_data_loss_prevention_policy/import.sh
Outdated
Show resolved
Hide resolved
mattdot
commented
Sep 4, 2024
…ty' of https://github.com/microsoft/terraform-provider-power-platform into mattdot/394-improve-documentation-of-import-functionality
mattdot
requested review from
leighatami,
ianjensenisme,
polatengin and
eduardodfmex
as code owners
mawasile
approved these changes
Sep 12, 2024
ianjensenisme
approved these changes
Sep 12, 2024
mattdot
deleted the
mattdot/394-improve-documentation-of-import-functionality
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes several updates to the documentation and examples related to importing resources in Terraform. The most important changes include adding new import instructions for various resources, updating example scripts, and enhancing the documentation templates.
Documentation Updates:
docs/guides/importing.md: Added a comprehensive guide on importing existing Power Platform resources into Terraform configurations. This includes sections on usingterraform import, import blocks, and generating configurations.docs/resources/billing_policy.md: Added import instructions for billing policies.docs/resources/data_loss_prevention_policy.md: Added import instructions for DLP policies.docs/resources/environment.md: Added import instructions for environment resources.Example Scripts:
examples/resources/powerplatform_billing_policy/import.sh: Added an example script for importing billing policies.examples/resources/powerplatform_data_loss_prevention_policy/import.sh: Added an example script for importing DLP policies.examples/resources/powerplatform_environment/import.sh: Added an example script for importing environment resources.Template Enhancements:
templates/guides/importing.md.tmpl: Created a template for the importing guide to standardize documentation.templates/resources/environment.md.tmpl: Improved the template by adding trimmed descriptions and structured sections for examples and import instructions. [1] [2]Codebase Updates:
internal/powerplatform/services/environment/models_environment.go: Added "Default" to the list of environment types.