Improving Logging/Tracing/Observability #440
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 11 commits
September 12, 2024 20:40
- Update devcontainer.json to include additional environment variables for Terraform and Azure CLI usage. - Add tasks.json file to simplify installation command in VS Code. - Update makefile to include test commands for unit and acceptance testing. - Update tools.go to import the tfplugindocs package for document generation.
Base automatically changed from
434-update-devcontainer-to-use-mcrmicrosoftcomazterraformlatest
to
main
September 16, 2024 12:21
mawasile
previously approved these changes
Sep 16, 2024
Remove the TraceId field from the ProviderConfig struct in the config.go file. Also remove the import of the uuid package and the assignment of TraceId in the Configure function of the provider.go file.
mattdot
changed the title
mattdot
requested review from
leighatami,
ianjensenisme,
polatengin and
eduardodfmex
as code owners
mawasile
approved these changes
Sep 16, 2024
eduardodfmex
approved these changes
Sep 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes significant updates to the Power Platform Terraform Provider, focusing on enhancing context management, improving logging, and updating build configurations.
Enhancements to Context Management and Logging:
internal/powerplatform/helpers/contexts.go: IntroducedEnterRequestContextandEnterProviderContextfunctions to manage request and provider contexts, including logging the start and end of requests.internal/powerplatform/api/request.go: AddedBuildCorrelationHeadersandbuildUserAgentmethods to include context-specific headers and user agent strings in API requests. [1] [2]internal/powerplatform/services/environment/resource_environment.go: Updated resource methods (Create,Read,Update,Delete,Configure) to utilize the new context management functions for improved logging and context handling. (F65710a7L33R68, [1] [2] [3] [4] [5] [6]Build Configuration Updates:
.goreleaser.yml: Updated theldflagsto include additional build information such asProviderVersion,Commit, andBranch.common/release.go: Added new variables (ProviderVersion,Commit,Branch) to store build information, set during the build/release process.API Client Improvements:
internal/powerplatform/api/api_client.go: ModifieddoRequestmethod to acceptcontext.Contextas a parameter to support context-specific operations.Provider Metadata and Configuration Enhancements:
internal/powerplatform/provider/provider.go: EnhancedMetadataandConfiguremethods to log additional information and handle context better. AddedTerraformVersiontoProviderConfig. [1] [2] [3] [4]Miscellaneous Changes:
.github/workflows/run_tests.yml: Updated the path for test coverage artifacts totest-coverage.cov.html.These changes collectively improve the maintainability, logging, and context management of the Power Platform Terraform Provider, ensuring better traceability and debugging capabilities.Published as a draft pr so that we can talk about design