Skip to content

Refactor test files to use dynamic resource group names #483

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 3, 2024

Conversation

mattdot
Copy link
Member

@mattdot mattdot commented Oct 2, 2024

This pull request introduces changes to the test files in the internal/services/licensing directory to ensure unique resource group names by appending a random number. The most important changes involve modifying the resource group names in various test functions and importing necessary packages.

Test Function Updates:

Package Imports:

  • Added math/rand/v2 and strconv imports to several test files to facilitate the generation of random numbers for resource group names. [1] [2] [3] [4]

@mattdot mattdot linked an issue Oct 2, 2024 that may be closed by this pull request
@mattdot mattdot self-assigned this Oct 2, 2024
@mattdot mattdot added the run-acceptance-tests PR tag for triggering acceptance tests label Oct 2, 2024
@mattdot mattdot marked this pull request as draft October 2, 2024 22:42
@mattdot mattdot marked this pull request as ready for review October 2, 2024 22:42
mawasile
mawasile previously approved these changes Oct 3, 2024
…rdResource_Validate_Disable_On_Delete test
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.26%. Comparing base (e153201) to head (4ffc078).
Report is 9 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #483      +/-   ##
==========================================
- Coverage   76.38%   76.26%   -0.13%     
==========================================
  Files          98       98              
  Lines       11207    11246      +39     
==========================================
+ Hits         8561     8577      +16     
- Misses       2048     2060      +12     
- Partials      598      609      +11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mawasile mawasile removed the run-acceptance-tests PR tag for triggering acceptance tests label Oct 3, 2024
@mawasile mawasile enabled auto-merge (squash) October 3, 2024 14:53
@mawasile mawasile merged commit bad3e9b into main Oct 3, 2024
8 checks passed
@mawasile mawasile deleted the mattdot/482-acceptance-tests-that-use-azapi-failing branch October 3, 2024 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Acceptance tests that use azapi failing
3 participants