Skip to content

Refactor environment API methods for create and update #503

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 25, 2024

Conversation

mawasile
Copy link
Contributor

This pull request to the internal/services/environment package introduces changes to improve the validation of environment details during creation and update operations. The most important changes include renaming existing validation methods for clarity, adding new methods for update validation, and updating the corresponding data transfer objects (DTOs) and tests.

Improvements to validation methods:

Updates to DTOs:

  • internal/services/environment/dto.go: Renamed validateEnvironmentDetailsDto to validateCreateEnvironmentDetailsDto and added a new validateUpdateEnvironmentDetailsDto for update validation.

Test enhancements:

@mawasile mawasile linked an issue Oct 24, 2024 that may be closed by this pull request
@mawasile mawasile added the bug Something isn't working label Oct 24, 2024
@mawasile mawasile merged commit 10dea01 into main Oct 25, 2024
8 checks passed
@mawasile mawasile deleted the mawasile/502-powerplatform_environment branch October 25, 2024 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

powerplatform_environment - update domain issue
3 participants