Refactor environment API methods for create and update #503
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request to the
internal/services/environment
package introduces changes to improve the validation of environment details during creation and update operations. The most important changes include renaming existing validation methods for clarity, adding new methods for update validation, and updating the corresponding data transfer objects (DTOs) and tests.Improvements to validation methods:
internal/services/environment/api_environment.go
: RenamedValidateEnvironmentDetails
toValidateCreateEnvironmentDetails
to better reflect its purpose. [1] [2] [3]internal/services/environment/api_environment.go
: Added a new methodValidateUpdateEnvironmentDetails
for validating environment details during updates.Updates to DTOs:
internal/services/environment/dto.go
: RenamedvalidateEnvironmentDetailsDto
tovalidateCreateEnvironmentDetailsDto
and added a newvalidateUpdateEnvironmentDetailsDto
for update validation.Test enhancements:
internal/services/environment/resource_environment_test.go
: Added a new testTestAccEnvironmentsResource_Validate_Domain_Uniqueness_On_Update
to validate domain uniqueness during environment updates.