Skip to content

fix: Fix wrong null offsets for json path index #43823

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: 2.5
Choose a base branch
from

Conversation

sunby
Copy link
Contributor

@sunby sunby commented Aug 11, 2025

pr: #43390
issue: #43315

@sre-ci-robot sre-ci-robot added the size/L Denotes a PR that changes 100-499 lines. label Aug 11, 2025
Copy link
Contributor

mergify bot commented Aug 11, 2025

@sunby Please associate the related pr of master to the body of your Pull Request. (eg. "pr: #")

@mergify mergify bot added dco-passed DCO check passed. do-not-merge/missing-related-pr kind/bug Issues or changes related a bug labels Aug 11, 2025
@sre-ci-robot sre-ci-robot added the do-not-merge/need-milestone generate by v2-label-manager label Aug 11, 2025
@sre-ci-robot
Copy link
Contributor

[INFO] PR Label Summary by Default
[SUCCESS] PR #43390 merged to master

[WARNING] Milestone not set

You can set milestone by commenting:
/set-milestone
Example:
/set-milestone 2.5.0

Use /refresh-label to update related check and label manually

Copy link

codecov bot commented Aug 11, 2025

Codecov Report

❌ Patch coverage is 46.53465% with 54 lines in your changes missing coverage. Please review.
✅ Project coverage is 80.59%. Comparing base (3baddd3) to head (b8e7e9d).
⚠️ Report is 1 commits behind head on 2.5.

Files with missing lines Patch % Lines
internal/core/src/index/JsonInvertedIndex.cpp 24.48% 37 Missing ⚠️
internal/core/src/index/JsonInvertedIndex.h 0.00% 14 Missing ⚠️
internal/core/src/exec/expression/ExistsExpr.cpp 33.33% 2 Missing ⚠️
internal/core/src/index/InvertedIndexTantivy.cpp 97.14% 1 Missing ⚠️

❌ Your patch check has failed because the patch coverage (46.53%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              2.5   #43823      +/-   ##
==========================================
- Coverage   80.65%   80.59%   -0.06%     
==========================================
  Files        1435     1435              
  Lines      207823   207881      +58     
==========================================
- Hits       167626   167552      -74     
- Misses      34332    34436     +104     
- Partials     5865     5893      +28     
Components Coverage Δ
Client 78.99% <ø> (ø)
Core 70.73% <46.53%> (-0.10%) ⬇️
Go 82.57% <ø> (-0.06%) ⬇️
Files with missing lines Coverage Δ
internal/core/src/index/InvertedIndexTantivy.h 51.72% <ø> (ø)
internal/core/src/index/InvertedIndexTantivy.cpp 85.00% <97.14%> (+1.35%) ⬆️
internal/core/src/exec/expression/ExistsExpr.cpp 83.18% <33.33%> (ø)
internal/core/src/index/JsonInvertedIndex.h 63.15% <0.00%> (-20.57%) ⬇️
internal/core/src/index/JsonInvertedIndex.cpp 64.78% <24.48%> (-21.39%) ⬇️

... and 32 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@sunby
Copy link
Contributor Author

sunby commented Aug 12, 2025

rerun ut

@mergify mergify bot added the ci-passed label Aug 12, 2025
@zhengbuqian
Copy link
Collaborator

/approve

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sunby, zhengbuqian

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot
Copy link
Contributor

[INFO] PR Label Summary by Default
[SUCCESS] PR #43390 merged to master

[WARNING] Milestone not set

You can set milestone by commenting:
/set-milestone
Example:
/set-milestone 2.5.0

Use /refresh-label to update related check and label manually

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. do-not-merge/need-milestone generate by v2-label-manager kind/bug Issues or changes related a bug size/L Denotes a PR that changes 100-499 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants