-
Notifications
You must be signed in to change notification settings - Fork 3.3k
enhance: better auto-detect of SVE options for the bitset library #43833
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
enhance: better auto-detect of SVE options for the bitset library #43833
Conversation
Signed-off-by: Alexandr Guzhva <[email protected]>
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: alexanderguzhva The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Invalid PR Title Format Detected Your PR submission does not adhere to our required standards. To ensure clarity and consistency, please meet the following criteria:
Required Title Structure:
Where Example:
Please review and update your PR to comply with these guidelines. |
Codecov Report✅ All modified and coverable lines are covered by tests. ❌ Your project check has failed because the head coverage (73.71%) is below the target coverage (77.00%). You can increase the head coverage or adjust the target coverage.
Additional details and impacted files@@ Coverage Diff @@
## master #43833 +/- ##
===========================================
- Coverage 79.33% 73.71% -5.62%
===========================================
Files 1556 331 -1225
Lines 225160 32204 -192956
===========================================
- Hits 178624 23740 -154884
+ Misses 40074 8464 -31610
+ Partials 6462 0 -6462
🚀 New features to boost your workflow:
|
#set_source_files_properties(detail/platform/arm/sve-inst.cpp PROPERTIES COMPILE_FLAGS "-mcpu=neoverse-v1") | ||
if (COMPILER_SUPPORTS_SVE AND COMPILER_HAS_ARM_SVE_HEADER) | ||
message(STATUS "SVE support for the bitset library is enabled") | ||
target_compile_definitions(milvus_bitset PRIVATE BITSET_ENABLE_SVE_SUPPORT=1) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we enlarge the scope?
@@ -622,7 +622,7 @@ init_dynamic_hook() { | |||
#endif | |||
|
|||
#if defined(__aarch64__) | |||
#if defined(__ARM_FEATURE_SVE) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why we change the macro? I thought this __ARM_FEATURE_SVE
will be auto-enabled once we set the flag during the compilation? Plz CMIIW
Enables the compilation of SVE code for the bitset library if a C++ compiler supports it.
There are two conditions for enabling the SVE code
-march=armv8-a+sve
arm_sve.h
header must be availableAFAIK,
gcc 7 does not support SVE
,gcc 8
andgcc 9
support SVE, but have noarm_sve.h
file, and onlygcc 10
has both.