fix: support struct vector fields in BulkWriter#3631
Conversation
|
Tick the box to add this pull request to the merge queue (same as
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3631 +/- ##
==========================================
+ Coverage 93.49% 93.78% +0.29%
==========================================
Files 69 69
Lines 15200 15238 +38
==========================================
+ Hits 14211 14291 +80
+ Misses 989 947 -42 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
a30b82c to
9fd70db
Compare
9fd70db to
49c6a70
Compare
49c6a70 to
94df45a
Compare
Signed-off-by: zhuwenxing <wenxing.zhu@zilliz.com>
94df45a to
cac8d73
Compare
|
/lgtm |
|
/assign @XuanYang-cn |
|
/hold |
|
/unhold |
XuanYang-cn
left a comment
There was a problem hiding this comment.
Found one blocking BulkWriter serialization regression.
nit: pymilvus/bulk_writer/__init__.py still omits ml_dtypes from the existing missing-package guard, so users who have the older bulk_writer extras except ml_dtypes get a raw import failure instead of the package install guidance; add ml_dtypes to expected_pkgs.
Signed-off-by: zhuwenxing <wenxing.zhu@zilliz.com>
a319f1a to
a8bdef7
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: XuanYang-cn, zhuwenxing The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
✅ Backport Created (cc @XuanYang-cn @SpadeA-Tang) |
|
Backport Created: 2.6 -> #3669 |
Cherry-pick of milvus-io#3631 and milvus-io#3658. Backports fix: support struct vector fields in BulkWriter to `2.6`. Backports fix(bulk_writer): preserve remote upload prefixes on Windows to `2.6`. pr: milvus-io#3631 pr: milvus-io#3658 Signed-off-by: pymilvus-bot <pymilvus@zilliz.com>
What this PR does
BulkFileType.JSONLand writes one JSON object per line with.jsonlsuffix.ml_dtypesfor BFLOAT16 JSON/CSV byte-vector decoding and includes it in thebulk_writerextra.Tests
python -m pytest -q tests/unit/test_bulk_writer_buffer.py tests/unit/test_local_bulk_writer.py tests/unit/test_remote_bulk_writer.pytest_import_struct_array_vector_subfield_all_file_typestest_import_struct_array_vector_subfield_with_local_bulk_writer