-
Notifications
You must be signed in to change notification settings - Fork 3
Switch to glasflow #228
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch to glasflow #228
Conversation
Tests will fail until |
Codecov ReportBase: 98.71% // Head: 98.71% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #228 +/- ##
=======================================
Coverage 98.71% 98.71%
=======================================
Files 48 48
Lines 3647 3648 +1
=======================================
+ Hits 3600 3601 +1
Misses 47 47
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
This should help track the exact version being used
Now that nessai uses glasflow the patch to LULinear is no longer needed
772cec0
to
7f70025
Compare
This MR changes the library used for normalising flows form
nflows
toglasflow
Motivation
nflows
is not actively maintained and the current release is from two years ago. Furthermore,nflows
is not available inconda
, a requirement for inclusion inigwn
.glasflow
is maintained by myself and others in the IGR so it gives us more control over the library. It includes a fork ofnflows
(https://github.com/igr-ml/nflows) and the option to fallback to standardnflows
if desired.Changes
Since
glasflow
includes the fork ofnflows
asglasflow.nflows
the main change is to the imports. There are other minor changes to the documentation and doc-strings.To-Do
glasflow
on PyPi