Skip to content

Switch to glasflow #228

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Sep 27, 2022
Merged

Switch to glasflow #228

merged 9 commits into from
Sep 27, 2022

Conversation

mj-will
Copy link
Owner

@mj-will mj-will commented Sep 22, 2022

This MR changes the library used for normalising flows form nflows to glasflow

Motivation
nflows is not actively maintained and the current release is from two years ago. Furthermore, nflows is not available in conda, a requirement for inclusion in igwn.

glasflow is maintained by myself and others in the IGR so it gives us more control over the library. It includes a fork of nflows (https://github.com/igr-ml/nflows) and the option to fallback to standard nflows if desired.

Changes
Since glasflow includes the fork of nflows as glasflow.nflows the main change is to the imports. There are other minor changes to the documentation and doc-strings.

To-Do

  • Wait for release of glasflow on PyPi
  • Update changelog

@mj-will mj-will added enhancement New feature or request flows Improvements or changes to the normalising flows labels Sep 22, 2022
@mj-will mj-will added this to the 0.7.0 milestone Sep 22, 2022
@mj-will
Copy link
Owner Author

mj-will commented Sep 22, 2022

Tests will fail until glasflow is released

@codecov-commenter
Copy link

codecov-commenter commented Sep 26, 2022

Codecov Report

Base: 98.71% // Head: 98.71% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (7f70025) compared to base (f967596).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #228   +/-   ##
=======================================
  Coverage   98.71%   98.71%           
=======================================
  Files          48       48           
  Lines        3647     3648    +1     
=======================================
+ Hits         3600     3601    +1     
  Misses         47       47           
Flag Coverage Δ
unittests 98.71% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
nessai/flowmodel/base.py 96.39% <ø> (ø)
nessai/flows/base.py 100.00% <100.00%> (ø)
nessai/flows/distributions.py 100.00% <100.00%> (ø)
nessai/flows/maf.py 100.00% <100.00%> (ø)
nessai/flows/nsf.py 100.00% <100.00%> (ø)
nessai/flows/realnvp.py 100.00% <100.00%> (ø)
nessai/flows/transforms.py 100.00% <100.00%> (ø)
nessai/flows/utils.py 98.42% <100.00%> (+0.03%) ⬆️
nessai/samplers/base.py 100.00% <100.00%> (ø)
nessai/utils/distributions.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@mj-will mj-will marked this pull request as ready for review September 27, 2022 12:25
@mj-will mj-will merged commit 8be0d7c into main Sep 27, 2022
@mj-will mj-will deleted the switch-to-glasflow branch September 27, 2022 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request flows Improvements or changes to the normalising flows
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants