Skip to content

BUG: Handle case where linear_transform='None' #414

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 13, 2024
Merged

Conversation

mj-will
Copy link
Owner

@mj-will mj-will commented Aug 13, 2024

This case seems to come up when using bilby_pipe.

I'll probably also port this fix back to a 0.13.x and make a bug fix release.

@mj-will mj-will added the bug Something isn't working label Aug 13, 2024
Copy link

codecov bot commented Aug 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.52%. Comparing base (423990a) to head (ef9fe08).
Report is 130 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #414   +/-   ##
=======================================
  Coverage   93.52%   93.52%           
=======================================
  Files          68       68           
  Lines        6646     6646           
=======================================
  Hits         6216     6216           
  Misses        430      430           
Flag Coverage Δ
unittests 93.52% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mj-will
Copy link
Owner Author

mj-will commented Aug 13, 2024

I've verified this fixes this issue with bilby_pipe

@mj-will mj-will merged commit 360e75f into main Aug 13, 2024
30 checks passed
@mj-will mj-will added this to the v0.13.2 milestone Aug 13, 2024
@mj-will mj-will mentioned this pull request Aug 13, 2024
@mj-will mj-will deleted the linear-transform-None branch August 13, 2024 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant