Skip to content

test: make cross-project attribution shell setup portable#766

Merged
mksglu merged 1 commit into
mksglu:nextfrom
NgoQuocViet2001:fix/windows-cross-project-attribution-shell
Jun 2, 2026
Merged

test: make cross-project attribution shell setup portable#766
mksglu merged 1 commit into
mksglu:nextfrom
NgoQuocViet2001:fix/windows-cross-project-attribution-shell

Conversation

@NgoQuocViet2001

Copy link
Copy Markdown
Contributor

Refs #765.

Fixes the Windows CI failure from the new cross-project attribution test added in 2e7a543.

What changed:

  • keep /bin/bash on POSIX, but let Windows use the default shell instead of hardcoding /bin/bash
  • normalize temp Windows paths to forward slashes before embedding them in Bash-style command fixtures

Why:

  • Windows CI was failing with spawnSync /bin/bash ENOENT
  • after that was fixed locally, the git -C fixture still misparsed C:\... paths as escapes and attribution fell back to the wrong project

Validation:

  • npx vitest run tests/integration/cross-project-attribution.test.ts → 5 passed
  • npm run typecheck
  • npm run build

@mksglu mksglu merged commit eac9373 into mksglu:next Jun 2, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants