Allow forwarding to fail to allow studio and flow to be active at the same time #2545
+9
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… same time Fixes mobile-dev-inc#2188 This is a bit of a workaround, both studio and flow forwards the driver-host-port (default 7001) for the android driver session. The forwarding fails for the second instance as the port is already open. But it doesn't really matter which driver-host is used, so let forwarding silently fail and let the android driver session continue.
|
Would be nice to see this PR land- this issue serious slows down development workflows. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a bit of a workaround, both studio and flow forwards the driver-host-port (default 7001) for the android driver session. The forwarding fails for the second instance as the port is already open. But it doesn't really matter which driver-host is used, so let forwarding silently fail and let the android driver session continue.
Proposed changes
copilot:summary
Testing
Launched maestro studio and while it was still running, launched a test flow with maestro test.
Also ran integration and unit tests.
Issues fixed
Fixes #2188