Add support for string interpolation in runScript file names #2547
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Will enable
runScript
commands to have js string interpolation in their file names. Example:This change moves some file handling from the
orchestra
module to theorchestra-models
module (including the correspondingInvalidFlowFile
exception), to be able to read the script files after thejsEngine
has done its magic and applied any string interpolation. This, however, means that any "file not found" issues are now not reported until runtime instead of when the maestro command is ran. After quick discussion with Dan Caseley, we figured this would be an acceptable tradeoff.Testing
I've added a test to the integration test suite, and built the Maestro CLI locally and tested on some sample flow.
Issues fixed
This change does not fully fix a single issue, but is a partial fix or the beginning on a fix to the following issues: