Skip to content

chore: upgrade ktor to 3.2.1 to avoid conflicting dependency #2603

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

amanjeetsingh150
Copy link
Collaborator

Proposed changes

Running maestro studio command gives an exception:

Exception in thread "main" java.lang.NoSuchMethodError: 'void io.ktor.server.application.Application.<init>(io.ktor.server.application.ApplicationEnvironment)'
        at io.ktor.server.engine.ApplicationEngineEnvironmentReloading.<init>(ApplicationEngineEnvironmentReloading.kt:67)
        at io.ktor.server.engine.ApplicationEngineEnvironmentBuilder.build(ApplicationEngineEnvironmentJvm.kt:75)
        at io.ktor.server.engine.ApplicationEngineEnvironmentKt.applicationEngineEnvironment(ApplicationEngineEnvironment.kt:48)
        at io.ktor.server.engine.EmbeddedServerKt.embeddedServer(EmbeddedServer.kt:92)
        at io.ktor.server.engine.EmbeddedServerKt.embeddedServer(EmbeddedServer.kt:65)
        at io.ktor.server.engine.EmbeddedServerKt.embeddedServer(EmbeddedServer.kt:40)
        at io.ktor.server.engine.EmbeddedServerKt.embeddedServer$default(EmbeddedServer.kt:32)
        at maestro.studio.MaestroStudio.start(MaestroStudio.kt:21)
        at maestro.cli.command.StudioCommand.call$lambda$0(StudioCommand.kt:77)
        at maestro.cli.session.MaestroSessionManager.newSession(MaestroSessionManager.kt:129)

This is because ktor 3.x.x is getting resolved transitively.

Testing

Locally using maestro studio command

Issues fixed

@@ -37,7 +37,7 @@ junit = "5.10.2"
kotlin = "2.2.0"
kotlinResult = "2.0.1"
kotlinx-serialization-json = "1.5.0"
ktor = "2.3.6"
ktor = "3.2.1"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The version on backend is 2.3.5, as per gradle deps, no?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants