remove unused emulators from exported image #5736
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tonis Tiigi <[email protected]>
tonistiigi
commented
Feb 13, 2025
| @@ -27,7 +27,6 @@ var qemuArchMap = map[string]string{ | |||
| "riscv64": "riscv64", | |||
| "arm": "arm", | |||
| "s390x": "s390x", | |||
| "ppc64": "ppc64", | |||
There was a problem hiding this comment.
ppc64 emulator was never part of the image anyway.
crazy-max
approved these changes
Feb 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New emulators that have been added to binfmt image are not actually referenced from the buildkit embedded loader. They are also rare enough not to be worth including. BuildKit can still use these emulators if they are installed into the kernel externally (what is recommended anyway).