fix: wcow: fix race condition in localmounter #5885
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the race condition with maximum 2 retries.
From several tests, 1 retry seems to be
enough, even without backoff. Added a simple
linear backoff for each retry starting at 30 ms.
fixes #5807
Here is a repro run + the mitigation - repro_run_8min.webm. See around t 1:55, on the 25th run. Hit the issue 1 in 100 runs, mostly it's been 2-3 in 100 runs.
Here's the repro script I was using:
To run, save the script in
repro.ps1
, run buildkitd with breakpoint set atsnapshot/localmounter_windows.go:78
, then: