Raw socket forwarding #6003
Merged
Raw socket forwarding #6003
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area/testing
area/client
area/docs
area/session
area/buildctl
labels
cpuguy83
force-pushed
the
raw_socket_forwarding
branch
9 times, most recently
from
b8722d2 to
abfefed
Compare
tonistiigi
reviewed
Jun 2, 2025
cpuguy83
force-pushed
the
raw_socket_forwarding
branch
from
abfefed to
ad589dd
Compare
This commit implements a new SSH provider in terms of ID and dialer functions and then implements the existing SSH provider using this. None of the SSH connection string parsing is updated to specifically support fraw mode. This will be handled in a follow-up commit. Signed-off-by: Brian Goff <[email protected]>
cpuguy83
force-pushed
the
raw_socket_forwarding
branch
from
ad589dd to
7b0eab6
Compare
tonistiigi
reviewed
Jun 2, 2025
| Dialer func(context.Context) (net.Conn, error) | ||
| } | ||
|
|
||
| func newRawProvider(confs []rawConfig) (session.Attachable, error) { |
There was a problem hiding this comment.
If rawConfig renamed to dialer as described in other comment then this can just be new SSHProvider or newSocketProvider.
tonistiigi
reviewed
Jun 2, 2025
cpuguy83
force-pushed
the
raw_socket_forwarding
branch
from
1e36a0c to
5944a97
Compare
AkihiroSuda
reviewed
Jun 3, 2025
In fraw mode it just does a raw proxy on the connection. There's no internal SSH agent or anything. Signed-off-by: Brian Goff <[email protected]>
This is not needed since we are not exporting the the underlying raw provider. Instead just convert the AgentConfig directly to a dialer. Signed-off-by: Brian Goff <[email protected]>
cpuguy83
force-pushed
the
raw_socket_forwarding
branch
from
5944a97 to
c39de5e
Compare
tonistiigi
approved these changes
Jun 3, 2025
AkihiroSuda
approved these changes
Jun 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.