resolver: allow reference matches for local image lookups #6029
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When looking up local images from container image store, Get() method only accepts direct name matches. This means that when image name is sent together with a digest value, it is not matched because containerd would expect digest to be part of the image name. Signed-off-by: Tonis Tiigi <[email protected]>
crazy-max
reviewed
Jun 13, 2025
Comment on lines
+255
to
+260
| name := named.Name() | ||
| tag := "latest" | ||
| if t, ok := named.(distreference.Tagged); ok { | ||
| tag = t.Tag() | ||
| } | ||
| name = name + ":" + tag |
There was a problem hiding this comment.
I think you could do this instead:
Suggested change
| name := named.Name() | |
| tag := "latest" | |
| if t, ok := named.(distreference.Tagged); ok { | |
| tag = t.Tag() | |
| } | |
| name = name + ":" + tag | |
| named = distreference.TagNameOnly(named) |
There was a problem hiding this comment.
Your example re-assigns to named (with a d); will that break the check further down (line 265?)
There was a problem hiding this comment.
Even with using a different name using TagNameOnly wouldn't have the desired effect iiuc. The goal is to remove the digest component from the reference. If you call TagNameOnly on ref that already has tag then it is just a no-op.
crazy-max
approved these changes
Jun 13, 2025
This was referenced Jun 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When looking up local images from container image store, Get() method only accepts direct name matches. This means that when image name is sent together with a digest value, it is not matched because containerd would expect digest to be part of the image name.
Fixes unnecessary requests in docker/buildx#3225 when containerd image store is enabled in moby.