Skip to content

gha cache: reload expired cache URLs #6053

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 27, 2025
Merged

Conversation

tonistiigi
Copy link
Member

In some conditions, there can be a pause between the initial load of the entry (that already contains a signed download URL even though we don't need it yet) and the time the cache blob is actually downloaded at the end of the build. One such case seems to be accessing SBOM scanner layers after the main build is completed. The signed URL is only valid for 10 minutes, and if more time has passed, then the old URL may receive a 403 error.

upstream version tonistiigi/go-actions-cache#40

@github-actions github-actions bot added the area/dependencies Pull requests that update a dependency file label Jun 26, 2025
@cpuguy83
Copy link
Member

Looks reasonable.

In some conditions there can be a pause between initial load of the
entry (that already contains signed download URL even though we don't
need it yet) and by the time cache is actually downloaded in the end
of the build. One such case seems to be accessing SBOM scanner layers
after the main build is completed. Signed URL is only valid for 10min
and if more time has passed then old URL may receive 403 error.

Signed-off-by: Tonis Tiigi <[email protected]>
@tonistiigi tonistiigi marked this pull request as ready for review June 26, 2025 17:28
@tonistiigi
Copy link
Member Author

Upstream PR was merged.

@crazy-max crazy-max merged commit 7bf2360 into moby:master Jun 27, 2025
216 of 221 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants