remotecache: refactor to new cache export interface #6129
+681
−632
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area/testing
area/util
area/buildkitd
area/remotecache
area/solver
labels
tonistiigi
force-pushed
the
cachev2-refactor
branch
from
3b01157 to
e5ab081
Compare
github-actions
bot
added
the
area/dependencies
tonistiigi
force-pushed
the
cachev2-refactor
branch
2 times, most recently
from
84984bb to
726cf39
Compare
This is a complete refactor of the cache export Go interface. Main aspect is to provide a strictly ordered walk of the cache tree instead of previous one where modification could be added to cache tree at any time by any component. This should address subtle concurrency issues and remove large parts of complicated (and likely buggy) normalization and deduplication steps. Signed-off-by: Tonis Tiigi <[email protected]>
Signed-off-by: Tonis Tiigi <[email protected]>
Signed-off-by: Tonis Tiigi <[email protected]>
Signed-off-by: Tonis Tiigi <[email protected]>
Signed-off-by: Tonis Tiigi <[email protected]>
tonistiigi
force-pushed
the
cachev2-refactor
branch
from
d90a601 to
daa2537
Compare
Signed-off-by: Tonis Tiigi <[email protected]>
Signed-off-by: Tonis Tiigi <[email protected]>
tonistiigi
force-pushed
the
cachev2-refactor
branch
from
949b652 to
9d27119
Compare
Signed-off-by: Tonis Tiigi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #5005
This is a complete refactor of the cache export Go interface.
Main aspect is to provide a strictly ordered walk of the
cache tree instead of previous one where modification could be
added to cache tree at any time by any component.
This should address subtle concurrency issues and remove
large parts of complicated (and likely buggy) normalization
and deduplication steps.