-
Notifications
You must be signed in to change notification settings - Fork 262
deps: update spacy to 3.8.7 #762
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary of Changes
Hello @cmgzn, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request updates the spacy
dependency to version 3.8.7. This change is crucial because the previously used version, 3.8.0, has been marked as yanked on PyPI, indicating it is no longer recommended for use. By upgrading, the project ensures it relies on a stable and supported version of the spacy
library, preventing potential issues related to the deprecated release.
Highlights
- Dependency Update: Updates the
spacy
library version from 3.8.0 to 3.8.7. - Reason for Update: The previous version (3.8.0) was marked as yanked on PyPI, making this update necessary for stability and best practices.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command>
or @gemini-code-assist <command>
. Below is a summary of the supported commands.
Feature | Command | Description |
---|---|---|
Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/
folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request correctly updates the spacy
dependency from a yanked version to a stable one, which is a necessary change. The update is consistently applied to both the main pyproject.toml
and the test configuration. I have one suggestion to improve the maintainability of the test setup to prevent configuration drift in the future.
@@ -157,7 +157,7 @@ def setUp(self): | |||
"pydantic>=2.0", | |||
"uv", | |||
"wordcloud", | |||
"spacy==3.8.0", | |||
"spacy==3.8.7", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for updating the spacy
version here. However, this hardcoded pyproject.toml
content is brittle and can easily get out of sync with the main pyproject.toml
, causing tests to run with a different dependency configuration. For instance, multiprocess
and dill
versions here already differ from the main file.
To improve maintainability, consider refactoring this to load dependencies directly from the actual pyproject.toml
file. This would prevent configuration drift and ensure tests are always aligned with the project's dependencies.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Submit this change later
spacy
from 3.8.0 to 3.8.7