Skip to content

build: update spacy dependency version #763

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 20, 2025
Merged

build: update spacy dependency version #763

merged 1 commit into from
Aug 20, 2025

Conversation

cmgzn
Copy link
Collaborator

@cmgzn cmgzn commented Aug 20, 2025

  • Upgrade spacy from 3.8.0 to 3.8.7
  • Version 3.8.0 has been marked as yanked on PyPI and is no longer recommended
  • Basic local testing passed
  • Need to run regression tests in this PR to fully confirm compatibility

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary of Changes

Hello @cmgzn, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request updates the spacy dependency to version 3.8.7. The previous version, 3.8.0, was marked as yanked on PyPI, indicating it is no longer recommended for use. This update ensures the project utilizes a stable and supported version of the spacy library, maintaining compatibility and reliability.

Highlights

  • Dependency Update: Upgraded the spacy library from version 3.8.0 to 3.8.7 to address the 3.8.0 version being yanked from PyPI.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request correctly updates the spacy dependency from version 3.8.0 to 3.8.7 in pyproject.toml and a related test file. This is a necessary update since the old version was yanked. However, I've identified a potential issue: the uv.lock file, which is used for dependency resolution by the project's lazy_loader, appears not to have been updated. This could cause runtime installation failures. I've left a comment with details on how to address this.

Copy link
Collaborator

@HYLcool HYLcool left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, and the regression tests are all passed.
https://github.com/modelscope/data-juicer/actions/runs/17091636975

@HYLcool HYLcool merged commit 668dca5 into main Aug 20, 2025
13 checks passed
@HYLcool HYLcool deleted the build/update-spacy branch August 20, 2025 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants