Skip to content

Fix watch bugs - #18

Open
tastelikefeet wants to merge 14 commits into
modelscope:mainfrom
tastelikefeet:feat/0618
Open

Fix watch bugs#18
tastelikefeet wants to merge 14 commits into
modelscope:mainfrom
tastelikefeet:feat/0618

Conversation

@tastelikefeet

Copy link
Copy Markdown
Collaborator

PR type

  • Bug Fix
  • New Feature
  • Document Updates
  • Server Enhancement

PR information

Write the detail information belongs to this PR.

Test results

Paste your test result here (if needed).

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request replaces the list command with status, updates the format conversion command to use --out-dir, and introduces a new backups command with filtering capabilities. It also refactors workspace conversion to filter out default templates and back up target files, resolves a stale file descriptor issue in the watcher daemon, and filters out stale deletes during incremental pushes. The review feedback highlights a critical test isolation issue where a restore test could overwrite files in the user's home directory, and suggests a more robust, unified parsing logic for filtering backups by framework and agent name.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread tests/cli/test_upload.py
Comment thread ultron/cli/commands.py Outdated
Comment thread ultron/cli/commands.py Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant