Skip to content

For windows 10 and windows 11, fixes bulding msys2 under case sensitive folder#6197

Merged
striezel merged 13 commits into
msys2:masterfrom
lygstate:case-sensative-folder
May 21, 2026
Merged

For windows 10 and windows 11, fixes bulding msys2 under case sensitive folder#6197
striezel merged 13 commits into
msys2:masterfrom
lygstate:case-sensative-folder

Conversation

@lygstate

@lygstate lygstate commented Apr 18, 2026

Copy link
Copy Markdown
Contributor

@lazka this MR is not huge, only character case changes, so it's easy to review.

@lygstate
lygstate force-pushed the case-sensative-folder branch from b9f57ef to 11e27c4 Compare April 18, 2026 04:26
@lygstate

Copy link
Copy Markdown
Contributor Author

@lazka Do I need split this MR into multiple PR?

@lazka

lazka commented Apr 26, 2026

Copy link
Copy Markdown
Member

no, it's fine

@lygstate
lygstate force-pushed the case-sensative-folder branch from 11e27c4 to 91472f0 Compare April 27, 2026 11:55
lygstate added 11 commits May 8, 2026 19:11
The `License` in source directory not named as `LICENSE`, under case-sensitive folder, it's will built failed.
PKGBUILD: line 21: cd: xxhash/src/xxhash-0.8.3: No such file or directory

ditto

Signed-off-by: Yonggang Luo <luoyonggang@gmail.com>
Signed-off-by: Yonggang Luo <luoyonggang@gmail.com>
…rt-BinHex.install for building under case-sensitive folder

Signed-off-by: Yonggang Luo <luoyonggang@gmail.com>
…gver}

Signed-off-by: Yonggang Luo <luoyonggang@gmail.com>
The extracted folder is Test-RequiresInternet-${pkgver}, not Test-Requiresinternet-${pkgver}

The package name is invalid when created.

Signed-off-by: Yonggang Luo <luoyonggang@gmail.com>
Signed-off-by: Yonggang Luo <luoyonggang@gmail.com>
This is for building under case-sensitive folder.

Signed-off-by: Yonggang Luo <luoyonggang@gmail.com>
Signed-off-by: Yonggang Luo <luoyonggang@gmail.com>
@lygstate
lygstate force-pushed the case-sensative-folder branch from 91472f0 to 2aebe95 Compare May 8, 2026 11:11
@lygstate

lygstate commented May 8, 2026

Copy link
Copy Markdown
Contributor Author

@lazka ping for merge

striezel added 2 commits May 21, 2026 20:20
This reverts commit 2aebe95.

Rebuilds are not required, because the package content does not
change here.
…folder."

This reverts commit d916682.

The commit would change the package name. This is possible, but
it should provide a migration path via provides/replaces or
similar fields in the PKGBUILD. Reverting for now.
@striezel
striezel merged commit 7b8b2e4 into msys2:master May 21, 2026
2 checks passed
@striezel

Copy link
Copy Markdown
Collaborator

I had to revert two commits before the merge:

  • commit 2aebe95, because it is not necessary to update package versions, because the package content will not change despite the renames (as seen in the file-diff)
  • commit d916682 because (and correct me if I'm wrong here) that would change the package name and I think this might cause problems for packages depending on it. We should probably use replaces and / or provides to give a smooth migration when updating to the new name.

@lygstate
lygstate deleted the case-sensative-folder branch May 22, 2026 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants