Skip to content

Conversation

bernardobelchior
Copy link
Member

Fixes failing Netlify deploys. E.g., 1, 2.

This is intended as a quick fix while I'm investigating the root cause.

@bernardobelchior bernardobelchior requested a review from a team August 13, 2025 14:48
@brijeshb42 brijeshb42 added the scope: code-infra Changes related to the core-infra product. label Aug 13, 2025
@mui-bot
Copy link

mui-bot commented Aug 13, 2025

Deploy preview: https://deploy-preview-19176--material-ui-x.netlify.app/

Bundle size report

Bundle Parsed size Gzip size
@mui/x-data-grid 0B(0.00%) 0B(0.00%)
@mui/x-data-grid-pro 0B(0.00%) 0B(0.00%)
@mui/x-data-grid-premium 0B(0.00%) 0B(0.00%)
@mui/x-charts 0B(0.00%) 0B(0.00%)
@mui/x-charts-pro 0B(0.00%) 0B(0.00%)
@mui/x-date-pickers 0B(0.00%) 0B(0.00%)
@mui/x-date-pickers-pro 0B(0.00%) 0B(0.00%)
@mui/x-tree-view 0B(0.00%) 0B(0.00%)
@mui/x-tree-view-pro 0B(0.00%) 0B(0.00%)

Details of bundle changes

Generated by 🚫 dangerJS against 1436da6

@bernardobelchior bernardobelchior added the type: bug It doesn't behave as expected. label Aug 13, 2025
@bernardobelchior bernardobelchior enabled auto-merge (squash) August 13, 2025 14:53
@Janpot
Copy link
Member

Janpot commented Aug 13, 2025

Probably relying on a script in monorepo that uses fs-extra. If that case we should consider adding it to dependencies in monorepo rather than devDependencies such that it gets installed correctly. To note that this only applies to the top-level monorepo package. workspaces are not at all considered by pnpm install. This is one of the reasons why we're moving away from the github dependency.

Also opening mui/mui-public#498

@bernardobelchior
Copy link
Member Author

Probably relying on a script in monorepo that uses fs-extra. If that case we should consider adding it to dependencies in monorepo rather than devDependencies such that it gets installed correctly. To note that this only applies to the top-level monorepo package. workspaces are not at all considered by pnpm install. This is one of the reasons why we're moving away from the github dependency.

Also opening mui/mui-public#498

Yeah, that's the issue. It is a dependency of netlify-plugin-cache-docs, but only a dev dependency of @mui/monorepo.

I'll see if it's easy to remove fs-extra from @mui/monorepo or add it as a dependency otherwise.

@bernardobelchior bernardobelchior merged commit 040047b into mui:master Aug 13, 2025
22 of 24 checks passed
@bernardobelchior bernardobelchior deleted the re-add-fs-extra branch August 13, 2025 15:04
@oliviertassinari oliviertassinari added type: regression A bug, but worse, it used to behave as expected. scope: docs-infra Changes related to the docs-infra product. and removed type: bug It doesn't behave as expected. scope: code-infra Changes related to the core-infra product. labels Aug 13, 2025
@oliviertassinari oliviertassinari changed the title [infra] Re-add fs-extra to fix Netlify deploy [docs-infra] Re-add fs-extra to fix Netlify deploy Aug 13, 2025
bernardobelchior added a commit to bernardobelchior/mui-x that referenced this pull request Aug 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope: docs-infra Changes related to the docs-infra product. type: regression A bug, but worse, it used to behave as expected.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants