feat(ensrainbow): refine handling of env vars #367
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
tk-o
reviewed
Mar 13, 2025
tk-o
reviewed
Mar 13, 2025
tk-o
reviewed
Mar 13, 2025
tk-o
reviewed
Mar 13, 2025
tk-o
reviewed
Mar 13, 2025
| logger.info(`Removing database directory at ${dataDir}...`); | ||
| await rm(dataDir, { recursive: true, force: true }); | ||
| logger.info("Database directory removed successfully."); | ||
| if (dirExists) { |
…cture Co-authored-by: Tomek Kopacki <[email protected]>
|
|
@Byczong is attempting to deploy a commit to the NameHash Team on Vercel. A member of the Team first needs to authorize it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#118
Refactor env vars, CLI args and configuration handling
This PR introduces a more standardized and modular approach to handling environment variables, command-line arguments, and configuration in ENSRainbow.
Changes
lib/env.tsfileapps/ensrainbow/src/utils/config.ts- Central configuration constantsapps/ensrainbow/src/utils/parsing-utils.ts- Pure parsing functionsapps/ensrainbow/src/utils/env-utils.ts- Environment variable handlingapps/ensrainbow/src/utils/command-utils.ts- CLI argument handlingapps/ensrainbow/src/utils/logger.ts- Updated to use newconfig.ts, moved some code to the new utils filesapps/ensrainbow/src/cli.ts- Refactored to use the new argument resolution utilities