-
-
Notifications
You must be signed in to change notification settings - Fork 7.1k
ISSUE-3924 Bumps mkdocs
and associated tools
#4024
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This attempts to fix nlohmann#3942 by way of upgrading `mkdocs` and the associated dependencies. As I mentioned in the issue, it looks like the hamburger menu glitch has been fixed in `mkdocs-material` upstream. **NOTE** I have been unable to test this change. I currently cannot get past an issue with `plantuml` when I attempt to run the docs with the suggested: ```sh make install_venv serve -C docs/mkdocs ``` Here is the issue. I get this error on both MacOS and a Ubuntu machine no matter which branch I am on. I don't see any mention of anyone else encountering this in another GitHub issue: ``` Exception: Failed to run plantuml: [Errno 2] No such file or directory: 'plantuml' make: *** [serve] Error 1 ``` But in the spirit of FOSS Friday, I wanted to get a PR up anyways. I was at least able to determine a cascading set of version number dependencies and I don't want to lose that effort. Cheers!
Here is the full error log from
|
It looks like I needed to Unfortunately, pulling the latest version of |
This attempts to fix #3942 by way of upgrading
mkdocs
and the associated dependencies. As I mentioned in the issue, it looks like the hamburger menu glitch has been fixed inmkdocs-material
upstream.NOTE
I have been unable to test this change. I currently cannot get past an issue with
plantuml
when I attempt to run the docs with the suggested:Here is the issue. I get this error on both MacOS and a Ubuntu machine no matter which branch I am on. I don't see any mention of anyone else encountering this in another GitHub issue:
But in the spirit of FOSS Friday, I wanted to get a PR up anyways. I was at least able to determine a cascading set of version number dependencies and I don't want to lose that effort.
Cheers!
Pull request checklist
Read the Contribution Guidelines for detailed information.
include/nlohmann
directory, runmake amalgamate
to create the single-header filessingle_include/nlohmann/json.hpp
andsingle_include/nlohmann/json_fwd.hpp
. The whole process is described here.Please don't
#ifdef
s or other means.