Skip to content

src:Elevate v8 namespaces of repeatedly referenced artifacts with - #24429

Closed
manilson wants to merge 1 commit into
nodejs:masterfrom
manilson:master
Closed

src:Elevate v8 namespaces of repeatedly referenced artifacts with#24429
manilson wants to merge 1 commit into
nodejs:masterfrom
manilson:master

Conversation

@manilson

@manilson manilson commented Nov 17, 2018

Copy link
Copy Markdown

'using' keyword in src/node_i18n.cc

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@targos targos targos left review comments
@jasnell jasnell jasnell approved these changes
@gireeshpunathil gireeshpunathil gireeshpunathil approved these changes
+2 more reviewers
@refack refack refack approved these changes
@thefourtheye thefourtheye thefourtheye approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. i18n-api Issues and PRs related to the i18n implementation.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

9 participants

@manilson @targos @refack @Trott @addaleax @jasnell @thefourtheye @gireeshpunathil @nodejs-github-bot