Skip to content

report: represent numbers as numbers - #25651

Closed
addaleax wants to merge 2 commits into
nodejs:masterfrom
addaleax:report-numbers
Closed

report: represent numbers as numbers#25651
addaleax wants to merge 2 commits into
nodejs:masterfrom
addaleax:report-numbers

Conversation

@addaleax

@addaleax addaleax commented Jan 22, 2019

Copy link
Copy Markdown
Member

report: refactor JSON writer

  • Support non-string entry types
  • Prefer single-character writes over string writes
  • Rename the state constants and adjust style to match more common Node.js style

report: represent numbers as numbers

Do not stringify numbers and boolean values when writing JSON.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cjihrig cjihrig cjihrig approved these changes
@richardlau richardlau richardlau approved these changes
@gireeshpunathil gireeshpunathil gireeshpunathil approved these changes
@BethGriggs BethGriggs BethGriggs approved these changes
+2 more reviewers
@mmarchini mmarchini mmarchini approved these changes
@mhdawson mhdawson mhdawson approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. report Issues and PRs related to process.report.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@addaleax @nodejs-github-bot @cjihrig @mmarchini @richardlau @gireeshpunathil @BethGriggs @mhdawson