Skip to content

[azure] updated storage version. #1477

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 6, 2025
Merged

Conversation

ismaelpuerto
Copy link
Contributor

Explain the changes

  1. updated storage account to version 2

Issues: Fixed #xxx / Gap #xxx

  1. storage v1 is marked as legacy type from Microsoft

Testing Instructions:

  • Doc added/updated
  • Tests added

@liranmauda
Copy link
Contributor

Hi @ismaelpuerto
Thank you for this PR.

While I couldn’t find any breaking changes between v1 and v2, I am not entirely certain that a general-purpose v1 account will be compatible with a general-purpose v2 type.

Before merging this PR, we must ensure with absolute certainty that it does not disrupt upgrades or workflows involving customers with general-purpose v1 accounts.

I suggest the following steps:

  1. Use a general-purpose v1 account to test a fresh installation with this change.
  2. Use a general-purpose v1 account with a working NooBaa setup to test an upgrade to NooBaa with this change.

@ismaelpuerto
Copy link
Contributor Author

Hello

We tested both situation and works fine. My principal fear was the upgrade in a production storage account and works fine.

@liranmauda
Copy link
Contributor

Thanks @ismaelpuerto
Could you rebase the PR from master?
After that, we could merge it.

@liranmauda
Copy link
Contributor

Thanks @ismaelpuerto for rebasing, could you squash the commits so we will have one commit?
After that, I will marge.

Signed-off-by: Ismael Puerto Freire <[email protected]>

Expand bucket replication documentation

Signed-off-by: Ben <[email protected]>

Add S3 compatibility documentation

Signed-off-by: Ben <[email protected]>

Noobaa/Operator: Display error message

While deleting OBC or Bucketclass which does not exist,
we should display an error message and should not silently
give success.

Signed-off-by: Ashish Pandey <[email protected]>

Add bucket types documentation

Signed-off-by: Ben <[email protected]>

Update `readme.md`

Signed-off-by: Ben <[email protected]>

noobaa/operator: Add tests for deletion

Adding tests for deletion of non exiisting OBC and Bucketclass

Signed-off-by: Ashish Pandey <[email protected]>

bucket notification - check pvcName, not pvc DFBUGS 988, 991 (noobaa#1485)

Signed-off-by: Amit Prinz Setter <[email protected]>

Fix for region fetch from GetAWSRegion()

Signed-off-by: Aayush Chouhan <[email protected]>

Bucket Notification - connect filename simplification (noobaa#1494)

Signed-off-by: Amit Prinz Setter <[email protected]>
@pull-request-size pull-request-size bot added size/XS and removed size/L labels Jan 6, 2025
@liranmauda liranmauda merged commit 5746766 into noobaa:master Jan 6, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants