Noobaa/Operator: Display error message #1482
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aspandey
force-pushed
the
error-message
branch
from
92e471c to
3416869
Compare
|
@shirady commented my changes just to see if the test will fail or not. |
aspandey
force-pushed
the
error-message
branch
2 times, most recently
from
853bf73 to
aa43076
Compare
While deleting OBC or Bucketclass which does not exist, we should display an error message and should not silently give success. Signed-off-by: Ashish Pandey <[email protected]>
aspandey
force-pushed
the
error-message
branch
from
aa43076 to
553c496
Compare
|
@shirady Patch is ready to be reviewed again. |
|
@aspandey I don't have additional comments. |
Done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While deleting OBC or Bucketclass which does not exist, we should display an error message and should not silently give success.
https://issues.redhat.com/browse/DFBUGS-201
As part of this I have also modified test_cli_functions.sh
Test under "delete_namespacestore_path" function was failing because we do not have a bucket which we are trying to delete. It was passing silently. In this function we are fetching the list of bucketclass and obc freshly and deleting those objects. I think that should cover the cases.