Skip to content

Handle low volume space for DB import #1581

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 7, 2025

Conversation

dannyzaken
Copy link
Member

Explain the changes

  • Check for the used space before initiating DB import to a new cluster.
    • If the used space is over 33 percent, request double the size for the PV
  • Implemented new util function ExecCommandInPod to execute a command inside a pod
    • Using ExecCommandInPod running df in the old DB pod to get used percentage
    • Added permission to the noobaa-operator role to execute commands in noobaa-db-pg-0 pod
  • Also handling updates of storage size to support PVC expansion (for supporting storage-classes)

Issues: Fixed #xxx / Gap #xxx

Testing Instructions:

  • Doc added/updated
  • Tests added

@dannyzaken dannyzaken force-pushed the danny-cnpg-upgrade branch 2 times, most recently from 21cc469 to cb56236 Compare April 7, 2025 13:43
- before initiating DB import to a new cluster, check for the used space.
  - If used space is over 33 percent, request double the size for the PV

Signed-off-by: Danny Zaken <[email protected]>
@dannyzaken dannyzaken force-pushed the danny-cnpg-upgrade branch from cb56236 to d6177da Compare April 7, 2025 13:47
Copy link
Contributor

@liranmauda liranmauda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dannyzaken dannyzaken merged commit 18bb208 into noobaa:master Apr 7, 2025
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants