Skip to content

Improve editorconfig #92

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Improve editorconfig #92

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 10 additions & 6 deletions .editorconfig
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,13 +1,17 @@
# Stop .editorconfig files search on current file
root = true

# Unix-style newlines with a newline ending every file
[*]
indent_style = space
indent_size = 2
end_of_line = lf
insert_final_newline = true
charset = utf-8
trim_trailing_whitespace = true
insert_final_newline = true
max_line_length = 2000
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This key doesn't seem standard. Do editors respect this? Also the value of 2000 looks a bit random to me.

Copy link
Author

@szepeviktor szepeviktor Aug 15, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do not use an IDE. (stone age viktor)
eclint in my CI workflow respects it.
SVG files have ~1000 long lines.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This feature request has 56 👍🏻-s.
editorconfig/editorconfig-vscode#272

block_comment_start = /*
block_comment = *
block_comment_end = */
Comment on lines +12 to +14
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm, these keys aren't present in the spec as well. Any reason to add them?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are for eclint to understand block comments.
What should I do?


# Indentation override
[*]
indent_style = space
indent_size = 2
[src/**]
max_line_length = 120
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See above. Also prettier, eslint and vscode are all configured to use 100 characters max.

Copy link
Author

@szepeviktor szepeviktor Aug 15, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are many lines in src/ exceeding 100 characters in length.
Should I modify this line?