-
-
Notifications
You must be signed in to change notification settings - Fork 716
Report destination of link in Word / Outlook legacy #17292
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@seanbudd, I have passed this PR to ready. Let me know if you wish me to move the original code in suitable text info object(s) rather than to keep it in the global commands class. Moving this code would surely be cleaner regarding the code organization; but I am more likely to break existing use cases. If you push for moving this code, have you an idea where I should move it? (advice appreciated) |
Co-authored-by: Sean Budd <[email protected]>
See test results for failed build of commit 9167cb9e7d |
See test results for failed build of commit c1eafa4af3 |
See test results for failed build of commit 46e38411b8 |
When in PowerPoint, NVDA+K does not work to report a link. Description of user facing changes In PowerPoint slides (edition mode), pressing NVDA+K will now report the link destination. This works in text areas as well as on shapes / charts / images that are links. Also 2 small fixes: Restored the Copy and Close buttons of the browseable message of NVDA+K that were removed by mistake in Report destination of link in Word / Outlook legacy #17292 In Windows UI, e.g. settings, pressing NVDA+K on a link does not report anymore that there is no link; it rather reports that the destination cannot be reported. Description of development approach Use PowerPoint object model Changed the global strategy to retrieve a link: first try from text infos; if not supported, try from the focused object.
Link to issue number:
None
Summary of the issue:
The command to report the destination of a link (
NVDA+k
) does not work in Word or Outlook when using object model (by default for Windows 10 users or users of older Office versions).Description of user facing changes
NVDA+k
will wow report the destination of the link in Word/Outlook object model.Description of development approach
_getLinkDataAtCaretPosition
function to report the required information on a link in aWordDocumentTextInfo
. Other text info classes can define such functions in the future to support the command in other content types.Testing strategy:
Manual tests:
Known issues with pull request:
None
Code Review Checklist:
@coderabbitai summary