-
Notifications
You must be signed in to change notification settings - Fork 47
CSAF 2 1 csdpr01 feedback #1108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
sthagen
wants to merge
199
commits into
master
Choose a base branch
from
csaf-2-1-csdpr01-feedback
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The CSD01 has duplicated heading labels visible in appendix C and this change-set fixes that. - Title Case aligned with heading text to be matched - Order aligned with order of sections in document - Added missing UUID Length entry (Added in v2.1)
The authors did not correctly separate the structural elements in section 2.3 namely the informative statement from its embedding list item. This commit fixes issue #1035 (2.3: Informative comment not displayed correctly).
- Closes #1066 Signed-off-by: Stefan Hagen <[email protected]>
- Closes #1064 - The other two defects noted in a comment of that ticket seem to have been already fixed on source level and in master Signed-off-by: Stefan Hagen <[email protected]>
- Closes #1048 Signed-off-by: Stefan Hagen <[email protected]>
- Closes #1047 Signed-off-by: Stefan Hagen <[email protected]>
- Closes #1049 Signed-off-by: Stefan Hagen <[email protected]>
- resolves #1085 - remove status from explanation (as it was a copy paste leftover) - update example from test data (as it was a copy paste mistake as well)
Co-authored-by: tschmidtb51 <[email protected]>
- resolves #1064 - change curly brackets to round brackets to correct syntax for Markdown links
* Add missing flags - addresses parts of #909, #341 - add valid example for 6.1.1 - add invalid example for 6.1.1 to detect result in flags - add valid example for 6.1.1 to detect result in flags * Updated editor config to cover lowercase makefile (#1040) Fixes #1039 (Editor config does not cover makefile). * GitHub Action - resolves #1073 - use main branch of csaf-validator-lib as it provides experimental support for CSAF 2.1 * GitHub Actions - fixes #1073 - change call signature for csaf-validator-lib also for CSAF 2.0 - unify test to base preset in both versions --------- Co-authored-by: Stefan Hagen <[email protected]>
…a-in-edited-by-list
…e-semantic-versioning
…o fix-test-6_1_53
- addresses parts of #1063 - correct JSON key spelling in prose
- addresses parts of #1063 - improve title for JSON key `distribution` - adapt prose
- addresses parts of #1061 - correct display of informative blocks by adding newlines around them
- addresses parts of #1061 - correct display of informative blocks by adding newlines around them - separartely correct a style issue
- resolves #1089 - update year in copyrigth to 2025
- resolves #1052 - remove limitation to `ssvc` namespace - rephrase to clarify that registered namespaces are in scope
Fixed Guidance Appendix Metadata
…-in-list Fixed informative block display in 2.3 at the source
…example-reference Reword potentially confusing example reference
…dited-by-list Remove superfluous comma in edited by list
…ix-1046 Comment Resolution CSD01PR: #1046
Comment Resolution CSD01PR: #1051
…ditorial VERS link
…o csaf-2-1-csdpr01-feedback-super-motion
- resolves #948 - add link to example
- addresses parts of #912 - add table references - add tables to test
- addresses parts of #912 - add missed testfile
Table references
…ditorial Editorial
- addresses parts of #963 - correct wording to avoid misunderstanding that leap seconds support would be optional in RFC 3339
…uper-motion Comment Resolution Log CSD01PR: Outcome of motions anticipation
- resolves #993 - refer to registered .well-known URL - clarify location
…ditorial Editorial
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Comment Resolution Log
Material
Content changes
Non-Material
Content changes
Editorial changes
Tool changes